[vlc-devel] [vlc-commits] lua: remove broken code

[Rémi Denis-Courmont]

On Mon, 21 Mar 2011 01:50:25 +0100 (CET), git at videolan.org (Pierre Ynard)
wrote:
> vlc | branch: master | Pierre Ynard <linkfanel at yahoo.fr> | Mon Mar 21
> 01:44:38 2011 +0100| [6addf026892913a7b2518485bc35d2f9385722d9] |
> committer: Pierre Ynard
> 
> lua: remove broken code
> 
> Only C userdata can set a garbage collector that way. Client sockets
> are leaked when the interface is stopped, because the destructor is
> never called. And given how the thread is cancelled in poll(), I can't
> see a simple way to call it.

As far as I know, the LUA interpreter is not cancellation-safe, so I don't
see how "the thread [could be] canceled in poll()" from within LUA.

-- 
Rémi Denis-Courmont
http://www.remlab.net/