[vlc-devel] [PATCH] Karaoke Audio Filter Module

[Rémi Denis-Courmont]

Le dimanche 20 mars 2011 19:44:53 Pankaj yadav, vous avez écrit :
> 2011/3/20 Rémi Denis-Courmont <remi at remlab.net>
> 
> > There still is a buffer read overflow. And you assume that the format is
> > stereo without checking.
> > 
> > i checked it. See
> 
>  +    if( i_channels < 2 )
> +    {
> +        msg_Warn( p_filter, "Karaoke Filter needs at least two channels."
> );
> +        return VLC_EGENERIC;
> +    }

Fair enough though I'm not sure the order of checks is right.

But I still see what looks a lot like a buffer overflow in DoWork().

+    for(int i = 0 ; i < i_samples; i++ )
+    {
+        p_out[0] = (p_in[0] -  p_in[1] )* p_sys->f_coefficient ;
+        p_out[1] = p_out[0] ;

-- 
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis