[vlc-devel] [PATCH] Added new commands in share/http/status.xml and modified pl_play

[Rémi Denis-Courmont]

Le dimanche 20 mars 2011 09:28:27 akash mehrotra, vous avez écrit :
> Added new commands pl_forcepause , pl_resume , pl_newplay and modified
> pl_play
> 
> pl_forcepause and pl_resume will only pause and resume, instead of toggling
> the state like pl_pause

No objection.

> pl_newplay will resume playback if paused, and do nothing if the video is
> currently playing. It will start playback only if video is stopped

Not very consistent. Based on the previous sentence, that should be 
pl_forceplay.

> pl_play has been modified so that it no longer restarts playback if called
> when the video is paused. It will still restart playback if the video is
> currently playing

This is a bit confused description. The implementation seems to be race-prone.

-- 
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis