[vlc-devel] [PATCH] Phosphor deinterlacer, reworked += 4

Juha Jeronen juha.jeronen at jyu.fi
Thu Mar 24 19:56:18 CET 2011

Hi (all),

I've updated the patch.

On 03/20/2011 11:21 PM, Rémi Denis-Courmont wrote:
> Le dimanche 20 mars 2011 23:03:35 Juha Jeronen, vous avez écrit :
>> On 03/20/2011 10:23 PM, Rémi Denis-Courmont wrote:
>>> I wonder if the long text is not too long for the user interface (not
>>> tested).
>> In the purely technical sense, it's not. I've tested it, and it displays
>> completely at least in the Qt GUI.
> Hmm OK. Still the longer the text, the more opportunities for translators to 
> screw up :-$

Yes. And more opportunities for a [
http://www.christov.net/cats/tldrcat.jpg ] in the users (though I doubt
that cats make up a significant user demographic).

Seriously, though, help text shortened. Now also vlc_CPU() is cached.
Otherwise this is identical to the previous version.

I made two patches, since RenderX() used to call vlc_CPU() in a loop,
too. The first patch fixes that. The second patch provides the new
deinterlacer, as usual.

RenderYadif() still calls vlc_CPU() once per call, and Open() a few
times when it's setting up the filter. I think that's not bad enough to
make it worth caching it in filter_sys_t. Thus, I went for the
"once-per-call" strategy in both patches.

Comments? Rémi? j-b? Laurent?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-RenderX-cache-vlc_CPU.patch
Type: text/x-patch
Size: 1443 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110324/27121d39/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Phosphor-deinterlacer.patch
Type: text/x-patch
Size: 44319 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110324/27121d39/attachment-0001.bin>

More information about the vlc-devel mailing list