[vlc-devel] [PATCH 1/4] sub-filter2 support

Laurent Aimar fenrir at elivagar.org
Fri Mar 25 15:04:37 CET 2011

On Fri, Mar 25, 2011 at 02:27:17PM +0100, Rémi Denis-Courmont wrote:
> On Fri, 25 Mar 2011 00:22:49 +0200, Yuval Tze <yuvaltze at gmail.com> wrote:
> > new filter type for processing subtitles.
> Checking the capability on-the-fly with module_find() will probably not
> work correctly. Some modules might have aliases. Furthermore, the chaining
> order would be violated if there is a mix of sub and sub2 in the same
> filter chain string.
> Thus, I would recommend using two different chain configuration strings
> even if it might be a bit confusing in a way.
 Well, in fact what is actually called sub-filter is not a way to filter subtitles
at all, but a way to create new ones from nothing. I think that the name of the 
current way is a bad one, and force to use "sub-filter2" instead of the more suited
"sub-filter" one. Renaming sub-filter into something else first, could be a solution
(no idea of a name).

 In any case, I think that using separate configuration seems the right thing to me.


More information about the vlc-devel mailing list