[vlc-devel] [PATCH 1/4] sub-filter2 support

[Yuval Tze]

Ok, I was trying to avoid duplicating the flow of subfilters, adding "2" to
every step.. it seems too messy.
At the moment the flow, from the global variable to the spu is:

- adding subfilter configuration string to "sub-filter" variable
- SubFilterCallback
- vout_ControlChangeSubFilters (creates new command)
- Thread / VOUT_CONTROL_CHANGE_SUB_FILTERS (executes the command)
- ThreadChangeSubFilters
- spu_ChangeFilters finally saves the string locally

Am I missing something? is there another way?

2011/3/25 Rémi Denis-Courmont <remi at remlab.net>

> On Fri, 25 Mar 2011 00:22:49 +0200, Yuval Tze <yuvaltze at gmail.com> wrote:
> > new filter type for processing subtitles.
>
> Checking the capability on-the-fly with module_find() will probably not
> work correctly. Some modules might have aliases. Furthermore, the chaining
> order would be violated if there is a mix of sub and sub2 in the same
> filter chain string.
> Thus, I would recommend using two different chain configuration strings
> even if it might be a bit confusing in a way.
>
> (And module_find() would need to be paired with module_release()).
>
> Best regards,
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110325/f539dcb9/attachment.html>