[vlc-devel] [vlc-commits] PVA: remove write-only variable

[Rémi Denis-Courmont]

Le dimanche 27 mars 2011 13:49:51 Jean-Baptiste Kempf, vous avez écrit :
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Sun Mar 27
> 12:42:47 2011 +0200| [10c867dd2b59db89d095bdb64d0146998c553207] |
> committer: Jean-Baptiste Kempf
> 
> PVA: remove write-only variable
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=10c867dd2b59db89d0
> > 95bdb64d0146998c553207
> 
> ---
> 
>  modules/demux/pva.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/demux/pva.c b/modules/demux/pva.c
> index b02f8dd..f94f5f6 100644
> --- a/modules/demux/pva.c
> +++ b/modules/demux/pva.c
> @@ -380,7 +380,6 @@ static void ParsePES( demux_t *p_demux )
>      demux_sys_t *p_sys = p_demux->p_sys;
>      block_t     *p_pes = p_sys->p_pes;
>      uint8_t     hdr[30];
> -    int         i_pes_size;
> 
>      unsigned    i_skip;
>      mtime_t     i_dts = -1;
> @@ -398,7 +397,7 @@ static void ParsePES( demux_t *p_demux )
>          block_ChainRelease( p_pes );
>          return;
>      }
> -    i_pes_size = GetWBE( &hdr[4] );
> +    GetWBE( &hdr[4] ); /* i_pes_size */

Uh?? What's the point in calling a pure function if you don't use the result?

-- 
Rémi Denis-Courmont
Looking for a job: http://www.remlab.info/
http://fi.linkedin.com/in/remidenis