[vlc-devel] [PATCH] Refactored deinterlacer module

[Juha Jeronen]

Hi (all),

On 05/01/2011 01:38 PM, Jean-Baptiste Kempf wrote:
> On Sun, May 01, 2011 at 01:30:29PM +0300, Juha Jeronen wrote :
>> If there is anyone who has contributed to the deinterlacer over the
>> years (browsing the git log indicates that several people have done at
>> least something :P ) and would like to have your name included, please
>> add it to the correct file(s).
> git blame -C -C files.c
>
> Then uniq, sort by authors and keep the ones that have contributed
> significantly...

Here are some results. For now without the "-C -C" - I'll run that later
against the latest tree.

Just before the refactor:

---8<---8<---8<---

jje at yamaneko:~/Documents/vlc$ git blame
104335bb00aebdbbbb7cfd9e72c9d75a90197a1e --
modules/video_filter/deinterlace.c | sed -r -e
"s/(\((\w|-|')+\s(\w|-|')+)(\s(\w|-|')+)?.*$/\1\4/; s/^.*\(//;" | sort |
uniq -c | sort -g -r
   3766 Juha Jeronen
    953 Laurent Aimar
    272 Sam Hocevar
    106 Rémi Denis-Courmont
     85 Damien Lucas
     76 Eric Petit
     69 Sigmund Augdal Helberg
     54 Christophe Massiot
     28 Gildas Bazin
     23 Rémi Duraffort
     23 Derk-Jan Hartman
      5 Clément Stenac
      4 Alexis Ballier
      2 Rafaël Carré
      2 Pierre d'Herbemont
      1 Yohann Martineau
      1 Jean-Paul Saman
      1 Antoine Cellerier

---8<---8<---8<---

For comparison, just before my first commit (February):

---8<---8<---8<---

jje at yamaneko:~/Documents/vlc$ git blame
87c209e5b4943a340dd7d0cd6e03918df664e9c9 --
modules/video_filter/deinterlace.c | sed -r -e
"s/(\((\w|-|')+\s(\w|-|')+)(\s(\w|-|')+)?.*$/\1\4/; s/^.*\(//;" | sort |
uniq -c | sort -g -r
   1002 Laurent Aimar
    277 Sam Hocevar
    106 Rémi Denis-Courmont
     85 Damien Lucas
     78 Eric Petit
     69 Sigmund Augdal Helberg
     57 Christophe Massiot
     28 Gildas Bazin
     23 Derk-Jan Hartman
     17 Rémi Duraffort
      5 Clément Stenac
      4 Alexis Ballier
      3 Antoine Cellerier
      2 Rafaël Carré
      2 Pierre d'Herbemont
      1 Yohann Martineau
      1 Jean-Paul Saman

---8<---8<---8<---

I guess at least Laurent should be acknowledged, as the X algorithm and
the Yadif glue code are his :)

 -J


P.S. For anyone interested, some documentation for the incantation used:

# - the sed magic is done in two steps to work around the need for a
non-greedy match
#   - the author name starts at the first '('
#   - the first step grabs "(name name [name]", discarding the rest
#     - the (\w|-|')+ pattern is used to allow hyphens and apostrophes
in the author name
#     - the author name may have two or three parts, hence the optional
(\s(\w|-|')+)?
#     - sed numbers the subexpressions linearly in order of appearance,
#       disregarding nested structure if any; hence we use \1\4 in the
replace string
#   - the second step discards everything before the name
#   - this leaves us with a list of authors, one name per line of code
# - we then sort the lines, and combine duplicates with uniq, counting
occurrences
# - finally, we sort the result in descending general numerical order
# - this results in a list of contributors in decreasing order of lines
of code written.