[vlc-devel] [PATCH] For MacOSX to support QTK capture device other than iSight 1/3

[Feurstein, Michael]

Hello,

thanks for this patch! I just tested it against the stable branch of VLC by manually adding your code - I couldn't find it on git. All in all it works fine with the following findings/questions:

(1) 32 bit / 64 bit
I tested it with an epiphan VGA2USB device - there seems to be an issue with QTKit discovering devices depending on 32 or 64 bit mode, then again I have no idea - it could also be an epiphan driver issue even though they state that their latest driver supports 64-bit kernel. I checked this with a separate implementation via Objective C and AppleScriptObjC and QTKit did not list the extra VGA2USB device in 64-bit mode. I don't know if this should be noted somewhere, it drove me nuts at first, because I didn't even think about the possibility it could have something to do with 32/64 bit mode.

In short:
VLC build 64 bit: can't discover additional video devices
VLC build 32 bit: successful discovery of additional devices
@Katsushi: can you confirm this / or is this an epiphan issue; if so I'd let them know.

(2) nib & co
How do I get the changes made in Open.nib to actually show up? I didn't find anything in the developer's corner. Tried rebuilding/compiling everything - no success. Right now I can't choose the video device via gui; I start it via command line and its uniqueID: /vlc-1.1.9-32bit/VLC.app/Contents/MacOS/VLC -vvv qtcapture://com.apple.QTKit.legacydevice-V2U13724-vdig-vusb-ephn

Apart from that this looks really promising and is a cool addition to VLC!

Thanks and best regards,
Michael Feurstein

On Apr 19, 2011, at 6:04 PM, Felix Paul Kühne wrote:

> Hello,
> 
> On 19.04.2011, at 15:20, Katsushi Kobayashi <ikob at riken.jp> wrote:
> 
>> Hi, 
>> 
>> This series is a patch for MacOSX to support additional capture device
>> in addition to default QTK capture device. I have once submitted the
>> same patch. Unfortunately, it was rejected because of my messy code :)
>> 
>> Also, the series includes some binary data for GUI definition.
> First of all, thanks for your contribution.
> 
> While I didn't compile your patch yet, so far, it looks fine for me as far as I can say. However, please resend your patches according to the guidelines available on [1], so you retain your copyright on merge. Additionally, please make the newly introduced term "None" localizable by adding the usual _NS wrapper.
> Did you test your patches against the stable or the unstable branch of VLC? (should be the latter) and are the used QTKit methods available within the 10.5 SDK?
> 
> Best regards,
> 
> Felix
> 
> [1] http://wiki.videolan.org/Sending_Patches_VLC
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel