[vlc-devel] Qt: open media file via drag&drop

Jakob Leben jakob.leben at gmail.com
Sat May 7 22:12:20 CEST 2011


On Sat, May 7, 2011 at 7:45 PM, Ilkka Ollakka <ileoo at videolan.org> wrote:

> On Sat, May 07, 2011 at 08:27:45PM +0300, Juha Jeronen wrote:
>


> > > On Sat, May 07, 2011 at 01:37:29AM +0200, Jakob Leben wrote:
> > >> For very long time already (couple of months) opening files by
> drag&dropping
> > >> them onto Qt interface does not work in the development version on my
> Linux
> > >> (Kubuntu, both 10.10 and 11.04).
>
> > Doesn't work for me in KDE4+Konqueror. Maybe something to do with KDE?
>
> Yes, seems that konqueror doesn't do Qt::CopyAction on default dnd, just
> Qt::MoveAction. So basicly it could be just to check if action if either
> of those and set it to CopyAction, but not sure if it has some effects
> (and kinda too tired to read documentation about it atm.)


The change in behavior from 1.1.x to current was introduced in commit
[eeb1cf53993].
Indeed, the previous behavior must have let through other actions than
Qt::CopyAction, while the current doesn't.
I don't see any reason for not responding to MoveAction as well. And I don't
see any reason for setting the action in MainInterface::dropEventPlay either,
as the drop event will be consumed and not processed any further so after
responding to the event it really doesn't matter what the action is anymore.

I propose the attached patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110507/21e13e41/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-MainInterface-respond-to-Qt-MoveAction-on-DnD-as-.patch
Type: text/x-patch
Size: 955 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110507/21e13e41/attachment.bin>


More information about the vlc-devel mailing list