[vlc-devel] [PATCHv2] dvdnav: only try to open *.iso files (fix #4741)

[Juha Jeronen]

On 05/08/2011 08:29 PM, Jean-Baptiste Kempf wrote:
> On Sun, May 08, 2011 at 08:23:52PM +0300, Juha Jeronen wrote :
>>> To open DVD with VLC we have:
>>>  - Classic /dev/cdrom /D:
>>>  - VIDEO_TS/ folders (dvd:// must be forced, now, I think, while this is
>>>      suboptimal)
>>>  - open .iso files (we don't support iso for VCD or BD)
>>>  - open .ifo files, inside VIDEO_TS folders
>> Yes.
> I am quite sure .ifo is out of issue here, since .ifo are treatead by
> VLC as playlists.

Hmm, .ifo doesn't work for me?

(Debug log output attached to the end of this message.)


> Normal /dev/cdrom /D: shouldn't be affected.

Mm.


> I don't know if VIDEO_TS/ would be affected, by this modification, maybe
> someone knows. :D

I think it shouldn't, since VIDEO_TS/ is a directory, and the S_ISDIR
check (before the modified part) will catch that.

That's for the theory... in practice, tested. VIDEO_TS still works after
the change (opened from Media > Open Disc > Browse...).


Here's the debug output (-vv) from trying to open an .ifo (Media > Open
File):

---8<---8<---8<---

[0x81f99b4] main playlist debug: incoming request - stopping current input
[0x81f99b4] main playlist debug: dead input
[0x81f99b4] main playlist debug: processing request item:
dvd:///home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO, node: Playlist, skip: 0
[0x81f99b4] main playlist debug: rebuilding array of current - root Playlist
[0x81f99b4] main playlist debug: rebuild done - 1 items, index 0
[0x81f99b4] main playlist debug: starting playback of the new playlist item
[0x81f99b4] main playlist debug: creating new input thread
[0xb700f9b4] main input debug: Creating an input for
'dvd:///home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO'
[0xb700f9b4] main input debug: selected audio language[0] ja
[0xb700f9b4] main input debug: selected audio language[1] any
[0xb700f9b4] main input debug: selected subtitle language[0] en
[0x81f99b4] main playlist debug: no fetch required for (null) (art
currently (null))
[0x81f99b4] main playlist debug: no fetch required for (null) (art
currently (null))
[0xb700f9b4] main input debug: thread started
[0xb700f9b4] main input debug: using timeshift granularity of 50 MiB, in
path '/tmp'
[0xb700f9b4] main input debug:
`dvd:///home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO' gives access `dvd'
demux `' path `/home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO'
[0xb700f9b4] main input debug: creating demux: access='dvd' demux=''
location='/home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO'
file='/home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO'
[0x84adb34] main demux debug: looking for access_demux module: 2 candidates
libdvdread: Using libdvdcss version 1.2.10 for DVD access
libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
[0x84adb34] dvdread demux warning: cannot open VMG info
[0x84adb34] main demux debug: no access_demux module matching "dvd"
could be loaded
[0x84adb34] main demux debug: TIMER module_need() : 6.455 ms - Total
6.455 ms / 1 intvls (Avg 6.455 ms)
[0xb700f9b4] main input debug: creating access 'dvd'
location='/home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO',
path='/home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO'
[0x84d4a6c] main access debug: looking for access module: 0 candidates
[0x84d4a6c] main access debug: no access module matched "dvd"
[0x84d4a6c] main access debug: TIMER module_need() : 3.961 ms - Total
3.961 ms / 1 intvls (Avg 3.961 ms)
[0xb700f9b4] main input error: open of
`dvd:///home/jje/Videos/test/VIDEO_TS/VIDEO_TS.IFO' failed

---8<---8<---8<---


 -J