[vlc-devel] [vlc-commits] Qt, selector: activate the SQL ML

[Jakob Leben]

Hello,

On Mon, May 9, 2011 at 11:06 AM, Jean-Baptiste Kempf <git at videolan.org>wrote:

> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Mon May  2
> 22:40:16 2011 +0200| [c1fd72005df18877637144885a8da01c832a2e5e] | committer:
> Jean-Baptiste Kempf
>
> diff --git a/modules/gui/qt4/components/playlist/selector.hpp
> b/modules/gui/qt4/components/playlist/selector.hpp
> index d97335e..ddac879 100644
> --- a/modules/gui/qt4/components/playlist/selector.hpp
> +++ b/modules/gui/qt4/components/playlist/selector.hpp
> @@ -43,7 +43,8 @@ class QLabel;
>  enum SelectorItemType {
>     CATEGORY_TYPE,
>     SD_TYPE,
> -    PL_ITEM_TYPE
> +    PL_ITEM_TYPE,
> +    SQL_ML
>  };
>

Why not SQL_ML_TYPE for consistency?


> @@ -189,8 +189,11 @@ void StandardPLPanel::searchDelayed( const QString&
> searchText )
>
>  /* Set the root of the new Playlist */
>  /* This activated by the selector selection */
> -void StandardPLPanel::setRoot( playlist_item_t *p_item )
> +void StandardPLPanel::setRoot( playlist_item_t *p_item, bool b )
>  {
> +    if( b ) //SQLML
> +        return;
> +
>     model->rebuild( p_item );
>  }
>

This use of the signal argument (bool) is quite non-transparent. Wouldn't it
be better to make another signal for SQL ML?

Cheers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110509/61c8e28f/attachment.html>