[vlc-devel] [vlc-commits] Qt, recents: elide on display in the menu, not at creation

[Rémi Denis-Courmont]

On Tue, 10 May 2011 13:42:37 +0200 (CEST), git at videolan.org (Jean-Baptiste
Kempf) wrote:
>    This file defines the main menus and the pop-up menu (right-click
menu)
> @@ -1486,11 +1487,16 @@ void QVLCMenu::updateRecents( intf_thread_t
> *p_intf )
>          {
>              for( int i = 0; i < l.size(); ++i )
>              {
> +                char *psz_temp = decode_URI_duplicate( qtu( l.at( i ) )
);

Err? Are you sure the anonymous QString object l.at(i) does not get
destroyed right before decode_URI_duplicate() is called? I am not sure how
C++ scopes objects in that case, and I would be more comfortable with a
non-anonymous...


-- 
Rémi Denis-Courmont
http://www.remlab.net/