[vlc-devel] [PATCH] Bug Fix in Subtitle Track Synchronization

[Laurent Aimar]

Hi,

On Tue, May 17, 2011 at 08:50:39PM +0530, Shash wrote:
> VLC has support for Video-Audio, Video-Subtitle track synchronization. (Tools
> -> Track Synchronization)
> On setting "Advance of Subtitle over Video" to negative value (say -2 seconds),
> video gets paused for the same duration. (2 seconds).
> 
> Details on the patch:
> 
> Patch takes care of offset introduced for track synchronization by
> appropriately modifying subtitle's presentation time.
> Also in input module, updating of presentation time on subtitle track
> synchronization is removed.
 Sadly it has too much side effects (breaks embed subtitles, or work only with
one demuxer) and is a bit too specialized (for example, doesn't work with external
audio files).

 I think it could be made better by simply changing the way input slaves are
synchronized (when possible, otherwise the old way should be used). The way
es_out SET_PCR is handled might need some changes (like creating a es_out
per input slave), but I am not sure.

Regards,

-- 
fenrir