[vlc-devel] [PATCH] 6 small npapi patch.

Rafaël Carré funman at videolan.org
Sun Nov 13 18:40:35 CET 2011

Le Sun, 13 Nov 2011 13:26:13 +0700,
Sergey Radionov <rsatom at gmail.com> a écrit :

> Patches needed for compilation of npapi and ActiveX under Visual Studio.

Patches 1, 2, and 4 applied, thanks.

Patch 5 rejected, your gecko headers are out of date
(this patch reverts d2e65e4462b9a634d5)

$ svn co http://npapi-sdk.googlecode.com/svn/trunk/headers
$ svn log headers/npfunctions.h

r5 | josh.aas at gmail.com | 2011-03-02 12:19:59 -0500 (mer. 02 mars 2011) | 1 ligne

Make NP_GetMIMEDescription return value const. r=smorgan

patch 3 and 6 (Visual Studio warnings) should be merged but I have a
few remarks:

There are a few float to long casts, shouldn't the interface be changed
to take a float as input?
fireOnMediaPlayerBufferingEvent, fireOnMediaPlayerTimeChangedEvent, etc

About the "!=0" addition I think it would be clearer if you add a "!!"
in front of the variable to make sure it is 0 or 1.
Does that fix the warning?

BTW could you have a look at the win64 patch I sent to the list? It was
for you since you are the only one who knows activex I think...
The patch is a bit ugly but if you have a better idea I am listening ^^

Rafaël Carré

More information about the vlc-devel mailing list