[vlc-devel] [PATCH] 6 small npapi patch.

[Rafaël Carré]

Le Mon, 14 Nov 2011 10:57:36 +0700,
Sergey Radionov <rsatom at gmail.com> a écrit :

> 2011/11/14 Rafaël Carré <funman at videolan.org>

> > Patch 5 rejected, your gecko headers are out of date
> > (this patch reverts d2e65e4462b9a634d5)
> >
> > $ svn co http://npapi-sdk.googlecode.com/svn/trunk/headers
> > $ svn log headers/npfunctions.h
> > ....
> >
> > r5 | josh.aas at gmail.com | 2011-03-02 12:19:59 -0500 (mer. 02 mars 2011) |
> > 1 ligne
> >
> > Make NP_GetMIMEDescription return value const. r=smorgan
> >
> Yes, you are right. But then Jean-Baptiste Kempf need update
> Contribs<http://people.videolan.org/%7Ejb/Contribs/contrib-20111017-win32-bin-gcc-4.4.4-runtime-3.17-only.tar.bz2>,
> it contains outdated gecko heders.

Yeah.

And since the declaration in my unix headers don't return const I
committed a workaround which work for both: see a9aa594f5

> > About the "!=0" addition I think it would be clearer if you add a "!!"
> > in front of the variable to make sure it is 0 or 1.
> > Does that fix the warning?
> >
> No, it is not work. I try to eliminate
> *
> warning C4800: 'int' : forcing value to bool 'true' or 'false' (performance
> warning)*
> 
> But '!' (and therefore '!!') need bool argument, so it is not eliminate
> problem.

Weird, we have a lot of pointers comparison using !

like: pointer = malloc(1234);
if (!pointer) ....

> So the more correct way (in C++) make bool from int, is compare it with
> zero.

> > BTW could you have a look at the win64 patch I sent to the list? It was
> > for you since you are the only one who knows activex I think...
> > The patch is a bit ugly but if you have a better idea I am listening ^^
> >
> Ok, I'll see it. And I'll make x64 support in my Visual Studio projects, to
> simplify testing.
> But tell me please ID or Comment of you win64 patch.

See http://article.gmane.org/gmane.comp.video.videolan.vlc.devel/80906

-- 
Rafaël Carré