[vlc-devel] [PATCH] prepare for VisualC

[Sergey Radionov]

18.11.2011 14:37, Rafaël Carré пишет:
> Le Fri, 18 Nov 2011 10:47:08 +0700,
> Sergey Radionov<rsatom at gmail.com>  a écrit :
>
>> 2011/11/17 Jean-Baptiste Kempf<jb at videolan.org>
>>
>>> On Thu, Nov 17, 2011 at 09:32:37PM +0700, Sergey Radionov wrote :
>>>> +#ifdef _MSC_VER
>>>> +
>>>> +const CATID CATID_SafeForScripting     =
>>>> +    {0x7dd95801, 0x9882, 0x11cf,
>>> {0x9f,0xa9,0x00,0xaa,0x00,0x6c,0x42,0xc4}};
>>>> +const CATID CATID_SafeForInitializing  =
>>>> +
>>>   {0x7dd95802,0x9882,0x11cf,{0x9f,0xa9,0x00,0xaa,0x00,0x6c,0x42,0xc4}};
>>>> +
>>>> +#else /*!_MSC_VER*/
>>>> +
>>>>   #include<_mingw.h>
>>>>
>>>>   #ifdef __MINGW64_VERSION_MAJOR
>>>> @@ -60,7 +69,7 @@ static DEFINE_GUID(CATID_SafeForScripting, \
>>>>        0x7DD95801, 0x9882, 0x11CF, 0x9F, 0xA9,
>>> 0x00,0xAA,0x00,0x6C,0x42,0xC4);
>>>>
>>>>   #endif /* __MINGW64_VERSION_MAJOR */
>>>> -
>>>> +#endif /*_MSC_VER*/
>>>
>>> I don't see why you can't use the same codepath here.
>>>
>>>
>> activex/main.cpp:
>>
>> *#ifdef __MINGW32__
>> #include<_mingw.h>
>> #endif
>>
>> #ifdef __MINGW64_VERSION_MAJOR
>>
>> #include<guiddef.h>
>
> This one is actually unneeded
Not I insert this line, so, I think, I may not it remove :)
>
>> #include<objsafe.h>
>
> Where are those macros defined in Windows headers?
>
> http://msdn.microsoft.com/en-us/library/aa751977(v=vs.85).aspx says
> CATID_SafeForInitializing is in objsafe.h so I think it should be:

You are right, those macros are defined in <objsafe.h>, so we don't need to define them...

>
> #include<objsafe.h>
Is MINGW32 has this header?


-- 
With best wishes,
Sergey Radionov