[vlc-devel] [vlc-commits] contrib: OSX use shared libraries

[Rafaël Carré]

Le Mon, 21 Nov 2011 10:12:20 +0100,
"Felix Paul Kühne" <fkuehne.videolan at googlemail.com> a écrit :

> 
> On 21.11.2011, at 08:10, Rémi Denis-Courmont wrote:
> 
> > On Mon, 21 Nov 2011 03:35:14 +0100 (CET), git at videolan.org (Rafaël Carré)
> > wrote:
> >> vlc | branch: master | Rafaël Carré <funman at videolan.org> | Sun Nov 20
> >> 21:22:05 2011 -0500| [4a7bb89cd823531b1129671d25f91047886b1eb7] |
> >> committer: Rafaël Carré
> >> 
> >> contrib: OSX use shared libraries
> > 
> > Using shared libraries in contrib is a bad idea.
> 
> Rémi is right here. We got quite a few libraries in the contribs which are also part of OS X installations by default or through tools like homebrew in quite a few different versions (libraries coming to mind are freetype, ncurses, libpng, libjpeg, and through homebrew libavcodec). Using shared libraries could slightly slim VLC's installation but will ultimately lead to unreproducible compatibility issues.
> 
> So, please revert.

It has to be tested before I revert, although I agree it's a good idea
to use static libs. extras/contrib added --disable-shared only for a
selected handful of libraries.
I did that because I ran into all sorts of problems, although it might
work now that the LDFLAGS are set correctly.

> Thanks!

-- 
Rafaël Carré