[vlc-devel] [PATCH] ActiveX: Sync argument of fireOnMediaPlayerBufferingEvent/fireOnMediaPlayerTimeChangedEvent/fireOnMediaPlayerPositionChangedEvent with libvlc_event_t

[Jean-Paul Saman]

On Tue, Nov 22, 2011 at 1:20 PM, Sergey Radionov <rsatom at gmail.com> wrote:
> 2011/11/22 Jean-Paul Saman <jpsaman at videolan.org>
>>
>> On Tue, Nov 22, 2011 at 4:31 AM, Sergey Radionov <rsatom at gmail.com> wrote:
>> > Re-posting. Just to be shure the patch was not forgotten.
>> >
>> > Or it has some problems?
>>
>> Patch looks OK for me.
>>
>> Could you check the mozilla plugin for the same issue?
>
> I've check npapi plugin:
>
> static void handle_changed_event(const libvlc_event_t* event, void *param)
> {
>     uint32_t   npcount = 1;
>     NPVariant *npparam = (NPVariant *) NPN_MemAlloc( sizeof(NPVariant) *
> npcount );
>
>     VlcPlugin *plugin = (VlcPlugin*)param;
>     switch( event->type )
>     {
> #ifdef LIBVLC120
>         case libvlc_MediaPlayerBuffering:
>             DOUBLE_TO_NPVARIANT(event->u.media_player_buffering.new_cache,
> npparam[0]);
>             break;
> #endif
>         case libvlc_MediaPlayerTimeChanged:
>             DOUBLE_TO_NPVARIANT(
>
> static_cast<double>(event->u.media_player_time_changed.new_time),
>                 npparam[0]);
>             break;
>         case libvlc_MediaPlayerPositionChanged:
>
> DOUBLE_TO_NPVARIANT(event->u.media_player_position_changed.new_position,
> npparam[0]);
>             break;
>         case libvlc_MediaPlayerSeekableChanged:
>
> BOOLEAN_TO_NPVARIANT(event->u.media_player_seekable_changed.new_seekable,
> npparam[0]);
>             break;
>         case libvlc_MediaPlayerPausableChanged:
>
> BOOLEAN_TO_NPVARIANT(event->u.media_player_pausable_changed.new_pausable,
> npparam[0]);
>             break;
>         case libvlc_MediaPlayerTitleChanged:
>
> BOOLEAN_TO_NPVARIANT(event->u.media_player_title_changed.new_title,
> npparam[0]);
>             break;
>         case libvlc_MediaPlayerLengthChanged:
>             DOUBLE_TO_NPVARIANT(
>
> static_cast<double>(event->u.media_player_length_changed.new_length),
>                 npparam[0]);
>             break;
>         default: /* ignore all other libvlc_event_type_t */
>             NPN_MemFree( npparam );
>             return;
>     }
>     plugin->event_callback(event, npparam, npcount, param);
> }
>
> so, it have no such functions...

I meant check the npapi plugin for the same issue wrt casting float
and libvlc_time_t correctly, which your ActiveX patch corrected.

Kind regards,

Jean-Paul Saman