[vlc-devel] Remove useless <unistd.h> inclusion in core

KO Myung-Hun komh78 at gmail.com
Thu Nov 24 16:21:33 CET 2011



Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Tue Nov 22 17:42:47 2011 +0200| [d692bb16f728377747b58016f5ac5c1f85952d30] | committer: Rémi Denis-Courmont
> 
> Remove useless <unistd.h> inclusion in core
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d692bb16f728377747b58016f5ac5c1f85952d30
> ---
> 
>  src/config/help.c |    5 -----
>  src/libvlc.c      |    6 ------
>  2 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/src/config/help.c b/src/config/help.c
> index cf309ef..e11ff8c 100644
> --- a/src/config/help.c
> +++ b/src/config/help.c
> @@ -32,11 +32,6 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <stdlib.h>
> -#ifdef HAVE_UNISTD_H
> -# include <unistd.h>
> -#elif defined( WIN32 ) && !defined( UNDER_CE )
> -# include <io.h>
> -#endif
>  #if defined( WIN32 ) && !defined( UNDER_CE )
>  static void ShowConsole (void);
>  static void PauseConsole (void);

This breaks the compilation on OS/2.

-----
  CC     config/help.lo
config/help.c: In function 'Usage':
config/help.c:277: error: implicit declaration of function 'isatty'
-----

> diff --git a/src/libvlc.c b/src/libvlc.c
> index 021f9f0..c26d7b9 100644
> --- a/src/libvlc.c
> +++ b/src/libvlc.c
> @@ -47,12 +47,6 @@
>  #include <string.h>
>  #include <stdlib.h>                                                /* free() */
>  
> -#ifdef HAVE_UNISTD_H
> -#   include <unistd.h>
> -#elif defined( WIN32 ) && !defined( UNDER_CE )
> -#   include <io.h>
> -#endif
> -
>  #include "config/vlc_getopt.h"
>  
>  #ifdef HAVE_LOCALE_H
> 

This breaks the compilation on OS/2.

-----
  CC     libvlc.lo
libvlc.c: In function 'libvlc_InternalCreate':
libvlc.c:186: error: implicit declaration of function 'isatty'
-----

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr




More information about the vlc-devel mailing list