[vlc-devel] Nightly build for Mac OS X 64bit is not internationalized

[Rafaël Carré]

Le Mon, 28 Nov 2011 12:43:16 +0900,
Naohiro KORIYAMA <nkoriyama at gmail.com> a écrit :

> Now, nightly build for Mac OS X 64 bit is not internationalized.
> This issue affect my build too.
> 
> The reason why VLC is not internationalized, a test GNU gettext in
> libintl  failed.
> If the libintl library is built as dynamic library, the test is passed.

Thanks for looking in the problem!

> CoreFoundation Framework is required when using libintl static
> library, but it isn't used on the test, so it fails.
> The test is described in m4/gettext.m4, and this script consider about
> the framework of Mac.
> A variable INTL_MACOSX_LIBS is set at m4/intlmacosx.m4, but this
> variable is not used on the test.

If the system is not Mac OS X, is the variable empty?

> On a trial basis, I changed the m4/gettext.m4 like this:
> 
> diff --git a/m4/gettext.m4 b/m4/gettext.m4
> index f84e6a5..5c595b8 100644
> --- a/m4/gettext.m4
> +++ b/m4/gettext.m4
> @@ -181,7 +181,7 @@ return * gettext ("")$gt_expression_test_code +
> _nl_msg_cat_cntr + *_nl_domain_b
>             [gt_save_CPPFLAGS="$CPPFLAGS"
>              CPPFLAGS="$CPPFLAGS $INCINTL"
>              gt_save_LIBS="$LIBS"
> -            LIBS="$LIBS $LIBINTL"
> +            LIBS="$LIBS $LIBINTL $INTL_MACOSX_LIBS"
>              dnl Now see whether libintl exists and does not depend on libiconv.
>              AC_TRY_LINK([#include <libintl.h>
>  $gt_revision_test_code
> 
> The test is passed and  VLC is built as internationalized application.
> But this change is too ad-hoc...
> 
> I think there  is no fault on VLC about this issue, so maybe it's not
> a suitable place to report.

If your patch works we can add it to the contrib build of gettext and
you can send your patch to gettext developers, then when we use a
correct version of gettext we can remove this patch from contrib build.

> Best regards,
> 



-- 
Rafaël Carré