[vlc-devel] [Patches] Dash: mostly cosmetics

[Hugo Beauzée-Luyssen]

On Fri, Nov 25, 2011 at 6:00 PM, Tobias Güntner <fatbull at web.de> wrote:
> Am 24.11.2011 17:45, schrieb Hugo Beauzée-Luyssen:
>>
>> +    Node    *segmentInfo = DOMHelper::getFirstChildElementByName( root,
>> "SegmentInfo");
>
> ...
>>
>> +    SegmentInfo *info = new SegmentInfo( segmentInfo->getAttributes() );
>
> Can segmentInfo be NULL?
>

Here is the patch!

However, since there's no SegmentInfo, a ElementNotPresentException is
raised, and never catched. Before fixing this, I guess we need to
decide whether exceptions are leaved or removed.
Regards,

-- 
Hugo Beauzée-Luyssen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dash-Avoid-crashing-when-there-s-no-SegmentInfo-node.patch
Type: text/x-patch
Size: 1477 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111128/d375d345/attachment.bin>