[vlc-devel] [vlc-commits] configure.ac: remove redundant comments

Rafaël Carré funman at videolan.org
Mon Nov 28 22:22:42 CET 2011


Le Mon, 28 Nov 2011 22:50:56 +0200,
"Rémi Denis-Courmont" <remi at remlab.net> a écrit :

> Le lundi 28 novembre 2011 22:48:00 Rafaël Carré, vous avez écrit :
> > vlc | branch: master | Rafaël Carré <funman at videolan.org> | Mon Nov 28
> > 02:46:42 2011 -0500| [f6f727c2f4dd0dd2a7bb3553f16af4bbc8ea2425] |
> > committer: Rafaël Carré
> > 
> > configure.ac: remove redundant comments
> 
> I completely disagree here. It was more readable (and I did not write all of 
> them). 

I think it is more readable this way

dnl
dnl Check stuff
dnl

or

dnl
dnl  mpc demux plugin
dnl
 AC_ARG_ENABLE(mpc,

=> the comments give no information at all

Perhaps more spacing between entries would make it clearer though

> And the config.h comments were following the autoconf convention. You 
> just broke it.

The convention is not followed everywhere, and we won't be often reading the config.h.in anyway

-- 
Rafaël Carré



More information about the vlc-devel mailing list