[vlc-devel] [Patch] Dash: Don't try to do something without a valid MPD manager

Hugo Beauzée-Luyssen beauze.h at gmail.com
Mon Nov 28 22:54:07 CET 2011


2011/11/28 Christopher Müller <christopher.mueller at itec.uni-klu.ac.at>:
> Why do you want to get rid of it? You have to consider that the MPD part will grow immensely if we implement the whole DASH specification. Furthermore there are a lot of profiles, therefore I don’t like that.
>

Hi,

I do agree, which is why the interface is still here, because it's a
good thing when it comes to extending the code.
However, I don't see the point in implementing an interface that will
always return NULL, and therefore that is must likely to cancel the
playback later, or worst, crash if return values are not check
accordingly, which is why I'd rather return NULL directly, remove the
NullAdapterLogic/NullManager implementations, as it doesn't change
much, but feels more natural in my opinion.

Regards,


-- 
Hugo Beauzée-Luyssen



More information about the vlc-devel mailing list