[vlc-devel] [vlc-commits] configure.ac: remove redundant comments
Rémi Denis-Courmont
remi at remlab.net
Tue Nov 29 07:32:04 CET 2011
On Mon, 28 Nov 2011 16:22:42 -0500, Rafaël Carré <funman at videolan.org>
wrote:
> dnl
> dnl mpc demux plugin
> dnl
> AC_ARG_ENABLE(mpc,
>
> => the comments give no information at all
It *does*. Besides, it gives makes separation between parts of the code
much easier to spot, especially with syntax highlighting.
>
> Perhaps more spacing between entries would make it clearer though
>
>> And the config.h comments were following the autoconf convention. You
>> just broke it.
>
> The convention is not followed everywhere, and we won't be often reading
> the config.h.in anyway
That is your problem. If you do not validate your own commits correctly,
do not come and whine that they get dropped.
--
Rémi Denis-Courmont
http://www.remlab.net/
More information about the vlc-devel
mailing list