[vlc-devel] [PATCH] demux/mp4: add parsing of mfra atom

[Jean-Baptiste Kempf]

On Tue, Nov 29, 2011 at 05:14:41PM +0100, fyhuel at viotech.net wrote :
> +static int MP4_ReadBox_mfro( stream_t *p_stream, MP4_Box_t *p_box )
Ok.

> +static int MP4_ReadBox_tfra( stream_t *p_stream, MP4_Box_t *p_box )

> +    uint8_t length_size_of_traf_num = p_tfra->i_lengths>>4;
> +    uint8_t length_size_of_trun_num = ( p_tfra->i_lengths & 0x0c )>>2;

spaces around ">>", please.

> +    for( uint32_t i=0; i < i_number_of_entries; i++ )

Spec says i = 1, why?

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device