[vlc-devel] [PATCH] Contribs: add headers for CrystalHD for win32

[Rémi Denis-Courmont]

It looks OK to me.
Patching directly in the target is not very conventional though.


On Wed, 30 Nov 2011 03:32:16 +0100, Jean-Baptiste Kempf <jb at videolan.org>
wrote:
> ---
>  contrib/src/crystalhd/SHA512SUMS  |    1 +
>  contrib/src/crystalhd/mingw.patch |   27 +++++++++++++++++++++++++++
>  contrib/src/crystalhd/rules.mak   |   16 ++++++++++++++++
>  3 files changed, 44 insertions(+), 0 deletions(-)
>  create mode 100644 contrib/src/crystalhd/SHA512SUMS
>  create mode 100644 contrib/src/crystalhd/mingw.patch
>  create mode 100644 contrib/src/crystalhd/rules.mak
> 
> diff --git a/contrib/src/crystalhd/SHA512SUMS
> b/contrib/src/crystalhd/SHA512SUMS
> new file mode 100644
> index 0000000..5ec8285
> --- /dev/null
> +++ b/contrib/src/crystalhd/SHA512SUMS
> @@ -0,0 +1 @@
>
+da996732b1a4ff86f9bb36ca70cd203c0456d613b0ebdcddf4a2e33c2dd6dd9c3211bf6f3df5dd4c6e6c4a5a53d2ba1f7cd00eff2b2bd247195b8870ebc73bcd
>  crystalhd_lgpl_includes.zip
> diff --git a/contrib/src/crystalhd/mingw.patch
> b/contrib/src/crystalhd/mingw.patch
> new file mode 100644
> index 0000000..539a1e7
> --- /dev/null
> +++ b/contrib/src/crystalhd/mingw.patch
> @@ -0,0 +1,27 @@
> +--- bc_dts_types.h.old	2011-11-30 03:20:14.715875756 +0100
> ++++ bc_dts_types.h	2011-11-30 03:21:25.692227718 +0100
> +@@ -38,7 +38,7 @@
> + typedef int	BOOL;
> + #endif
> + 
> +-#ifdef WIN32
> ++#ifdef _MSC_VER
> +     typedef unsigned __int64  	U64;
> + #else
> +     typedef unsigned long long  U64;
> +@@ -81,6 +81,7 @@
> + 
> + #else
> + 
> ++#ifndef HAVE_STDINT_H
> + #ifndef uint64_t
> + typedef struct _uint64_t {
> + 	unsigned long low_dw;
> +@@ -103,6 +104,7 @@
> + #ifndef uint8_t
> + typedef unsigned char	uint8_t;
> + #endif
> ++#endif /* STDINT_H */
> + #endif
> + 
> + #endif
> diff --git a/contrib/src/crystalhd/rules.mak
> b/contrib/src/crystalhd/rules.mak
> new file mode 100644
> index 0000000..1da3107
> --- /dev/null
> +++ b/contrib/src/crystalhd/rules.mak
> @@ -0,0 +1,16 @@
> +# CrystalHD headers
> +
> +CRYSTAL_HEADERS_URL :=
>
http://www.broadcom.com/docs/support/crystalhd/crystalhd_lgpl_includes.zip
> +
> +$(TARBALLS)/crystalhd_lgpl_includes.zip:
> +	$(call download,$(CRYSTAL_HEADERS_URL))
> +
> +CRYSTAL_SOURCES := crystalhd_lgpl_includes.zip
> +
> +.sum-crystalhd: $(CRYSTAL_SOURCES)
> +
> +.crystalhd: $(CRYSTAL_SOURCES) .sum-crystalhd
> +	mkdir -p -- "$(PREFIX)/include/libcrystalhd"
> +	unzip $< -d "$(PREFIX)/include/libcrystalhd"
> +	patch -p0 -f -d $(PREFIX)/include/libcrystalhd <
> ../src/crystalhd/mingw.patch
> +	touch $@

-- 
Rémi Denis-Courmont
http://www.remlab.net/