[vlc-devel] [PATCH] demux/mp4: add parsing of mfra atom

Frederic YHUEL fyhuel at viotech.net
Wed Nov 30 17:48:54 CET 2011

>>> +    for( uint32_t i=0; i < i_number_of_entries; i++ )
>> Spec says i = 1, why?
> Because C arrays are zero-indexed :-)
> Besides, Laurent Aimar did like that elsewhere in the code, see "elst"
> and "stsz" atoms for examples.

Actually the spec isn't homogeneous with for loops. In the definition
of "stsd" atom, they even declare the counter "i", as if it was C code

> I'll send a new patch.

Here it is.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-demux-mp4-add-parsing-of-mfra-atom.patch
Type: text/x-diff
Size: 8712 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111130/639d97ef/attachment.patch>

More information about the vlc-devel mailing list