[vlc-devel] [PATCH] omxil: Add reference counting around the OMX Core loading and initialization

Rémi Denis-Courmont remi at remlab.net
Sun Oct 2 21:13:44 CEST 2011


Le dimanche 2 octobre 2011 22:07:25 Martin Storsjö, vous avez écrit :
> This avoids deinitializing the global OMX Core if a second
> instance of the module is initialized (e.g. for testing whether
> it can handle decoding another stream) and deinitialized while
> the first instance still is active.

Do you really need two reference counters?

In any case, they should be unsigned. I would also rather the reference 
counters be _explicitly_ initialized to 0. I know the C standard requires it 
implicitly, but it is ugly :-)

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis



More information about the vlc-devel mailing list