[vlc-devel] [PATCH] amem: channel mapping + typo

XilasZ xilasz at gmail.com
Sun Oct 2 21:26:58 CEST 2011


forget what i just said, didn't see the test before the switch.

Can you change it or should i sent another patch ?

On Sun, Oct 2, 2011 at 9:25 PM, XilasZ <xilasz at gmail.com> wrote:

> In theory yes, but since the value comes from the setup callback outside
> libvlc, we can't be sure. i think it's better to give an error message.
>
>
> 2011/10/2 Rémi Denis-Courmont <remi at remlab.net>
>
>> Le dimanche 2 octobre 2011 22:17:33 XilasZ, vous avez écrit :
>> > No particular reason, it was done that way in the aout i copy/paste it
>> from
>> > (don't know which one, they are all different).
>> >
>> > But your are right it makes more sense in 'case 2', 'default' should be
>> a
>> > "format not supported" case.
>>
>> default should actually be assert(0). It's impossible.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>> http://fi.linkedin.com/in/remidenis
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> http://mailman.videolan.org/listinfo/vlc-devel
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111002/f6bff3b7/attachment.html>


More information about the vlc-devel mailing list