[vlc-devel] [pulseaudio-discuss] [PATCH 2/2] PulseAudio: negotiate digital pass-through for A/52 and DTS

[Rémi Denis-Courmont]

Le lundi 3 octobre 2011 21:50:52 Pierre-Louis Bossart, vous avez écrit :
> > +#if PA_CHECK_VERSION(1,0,0)
> > +        case VLC_CODEC_A52:
> > +            format = VLC_CODEC_SPDIFL;
> > +            encoding = PA_ENCODING_AC3_IEC61937;
> > +            ss.format = HAVE_FPU ? PA_SAMPLE_FLOAT32NE :
> > PA_SAMPLE_S16NE;
> > +            break;
> 
> This test doesn't seem right. Probably a copy/paste mistake? The IEC data
> need to be stored in 16-bit data no matter if your hardware has a FPU or
> not.

That is the fallback PCM format in case the sink rejects S/PDIF. That ALSA 
wants S16 for S/PDIF is the internal cooking of the PulseAudio sink, right?

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis