[vlc-devel] [PATCH 1/3] qtsound: added audio capture functionality for MAC OS X

[Jean-Baptiste Kempf]

On Wed, Oct 05, 2011 at 02:10:07PM +0200, Michael Feurstein wrote :
>  dnl
> -dnl QTCapture
> -AC_ARG_ENABLE(macosx-qtcapture,
> -  [  --enable-macosx-qtcapture Mac OS X qtcapture (iSight) module (default enabled on Mac OS X)])
> -if test "x${enable_macosx_qtcapture}" != "xno" &&
> -  (test "${SYS}" = "darwin" || test "${enable_macosx_qtcapture}" = "yes")
> +dnl QTKit
> +AC_ARG_ENABLE(macosx-qtkit,
> +  [  --enable-macosx-qtkit Mac OS X qtkit framework for video and audio (default enabled on Mac OS X)])
> +if test "x${enable_macosx_qtkit}" != "xno" &&
> +  (test "${SYS}" = "darwin" || test "${enable_macosx_qtkit}" = "yes")
>  then
>    VLC_ADD_LIBS([qtcapture], [-Wl,-framework,Cocoa])
>    VLC_ADD_LIBS([qtcapture], [-Wl,-framework,QTKit])
> @@ -2136,9 +2136,12 @@ then
>    VLC_ADD_LIBS([qtcapture], [-Wl,-framework,QuartzCore])
>    VLC_ADD_LIBS([qtcapture], [-Wl,-framework,CoreVideo])
>    VLC_ADD_PLUGIN([qtcapture])
> +  VLC_ADD_LIBS([qtsound], [-Wl,-framework,Cocoa])
> +  VLC_ADD_LIBS([qtsound], [-Wl,-framework,QTKit])
> +  VLC_ADD_LIBS([qtsound], [-Wl,-framework,CoreAudio])
> +  VLC_ADD_PLUGIN([qtsound])
>  fi
>  
> -

Why removing a line?

> +
> +AC_ARG_ENABLE(macosx-eyetv,
> +  [  --enable-macosx-eyetv   Mac OS X EyeTV (TNT Tuner) module (default enabled on Mac OS X)])
> +if test "x${enable_macosx_eyetv}" != "xno" &&
> +  (test "${SYS}" = "darwin" || test "${enable_macosx_eyetv}" = "yes")
> +then
> +  VLC_ADD_LIBS([access_eyetv], [-Wl,-framework,Foundation])
> +  VLC_ADD_PLUGIN([access_eyetv])
> +fi
> +
> +AC_ARG_ENABLE(macosx-vlc-app,
> +  [  --enable-macosx-vlc-app build the VLC media player (default enabled on Mac OS X)])
> +AM_CONDITIONAL(BUILD_MACOSX_VLC_APP, [test "${enable_macosx_vlc_app}" != "no" &&
> +    (test "${SYS}" = "darwin" || test "${enable_macosx_vlc_app}" = "yes") ])
> +

No. This shouldn't be added.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device