[vlc-devel] [PATCH 0/2] Add avio url output support (for rtmp)

[Laurent Aimar]

On Mon, Oct 03, 2011 at 09:55:00PM +0300, Rémi Denis-Courmont wrote:
> Le lundi 3 octobre 2011 21:36:46 keary.griffin at unwiredappeal.com, vous avez 
> écrit :
> > 2)  The second attempts to allow more than one concurrent user of the
> > avio module, by using thread local storage.  Previously since avio only
> > allowed a single callback to be specified without parameters, it was
> > impossible to tell which "stream" it was checking on.  I've tested this and
> > it seems to work, but someone with a better understanding of libavformat
> > and/or VLC tls may want to take a peek.
> 
> The core looks correct though I would use an unsigned reference counter.
> 
> But it would be a lot better to get libavio fixed. Callbacks without an opaque 
> data pointer are insane.
 There was a patch about that on one of the ffmpeg/libav ML, so it might be fixed
in the future.

Otherwise, I agree, it's way to ugly to have to workaround such limited/broken API.

-- 
fenrir