[vlc-devel] [PATCH 1/3] qtsound: added audio capture functionality for MAC OS X

[Feurstein, Michael]

On Oct 5, 2011, at 3:11 PM, Rémi Denis-Courmont wrote:

On Wed,  5 Oct 2011 14:10:07 +0200, Michael Feurstein
<michael.feurstein at gmail.com<mailto:michael.feurstein at gmail.com>> wrote:
Tested with Built-in Input, Built-in Microphone and Griffin iMic USB
system
Usage: qtsound://"Built-In Input" or qtsound://"iMic USB audio system"
---
configure.ac              |   30 ++-
modules/access/Modules.am |    1 +
modules/access/qtsound.m  |  562
+++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 587 insertions(+), 6 deletions(-)
create mode 100644 modules/access/qtsound.m

diff --git a/configure.ac b/configure.ac
index 02d7c72..a4e43be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2124,11 +2124,11 @@ then
fi

dnl
-dnl QTCapture
-AC_ARG_ENABLE(macosx-qtcapture,
-  [  --enable-macosx-qtcapture Mac OS X qtcapture (iSight) module
(default enabled on Mac OS X)])
-if test "x${enable_macosx_qtcapture}" != "xno" &&
-  (test "${SYS}" = "darwin" || test "${enable_macosx_qtcapture}" =
"yes")
+dnl QTKit
+AC_ARG_ENABLE(macosx-qtkit,
+  [  --enable-macosx-qtkit Mac OS X qtkit framework for video and audio
(default enabled on Mac OS X)])
+if test "x${enable_macosx_qtkit}" != "xno" &&
+  (test "${SYS}" = "darwin" || test "${enable_macosx_qtkit}" = "yes")
then
  VLC_ADD_LIBS([qtcapture], [-Wl,-framework,Cocoa])
  VLC_ADD_LIBS([qtcapture], [-Wl,-framework,QTKit])
@@ -2136,9 +2136,12 @@ then
  VLC_ADD_LIBS([qtcapture], [-Wl,-framework,QuartzCore])
  VLC_ADD_LIBS([qtcapture], [-Wl,-framework,CoreVideo])
  VLC_ADD_PLUGIN([qtcapture])
+  VLC_ADD_LIBS([qtsound], [-Wl,-framework,Cocoa])
+  VLC_ADD_LIBS([qtsound], [-Wl,-framework,QTKit])
+  VLC_ADD_LIBS([qtsound], [-Wl,-framework,CoreAudio])
+  VLC_ADD_PLUGIN([qtsound])
fi

There is not much point in cluttering configure with constant values. You
might as well pass them as _LIBADD or _LDFLAGS in the Makefile
(Modules.am).


I now adpated all the changes (i snipped them out - too much text). This one however I can't seem to solve or find an already in use example. I looked into modules/audio_output/pulse.c and how it is loaded. Now I'm not quite sure if my approach is correct. should I:

add something like QTSOUND_LIBS = -Wl,-framework,CoreAudio -Wl,-framework,QTKit -Wl,-framework,Cocoa to the actual configure file, add the plugin in configure.ac (VLC_ADD_PLUGIN) and reference the source and libs in Modules.am (libqtsound_plugin_la_SOURCES = qtsound.m libqtsound_plugin_la_LIBADD = $(AM_LIBADD) $(QTSOUND_LIBS)) ?

however when looking at the configure file, i guess it is not meant for manual editing.

help greatly appreciated

Thanks!
P.S. hope the quotation is now legible
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111012/28d6bf89/attachment.html>