[vlc-devel] [PATCH] Adjusted meta data signalling to only send events when the meta data has actually changed.
johannesmarbach at googlemail.com
Wed Oct 12 16:20:21 CEST 2011
Just to make sure: In that section of my patch you posted, which of the
values do you suspect to possibly be changed after the if statement? The old
meta, that is input_item_GetNowPlaying( p_input->p->p_item ), or the new
meta, that is p_pgrm->psz_now_playing?
The problem with input_item_SetNowPlaying is, that it fires the meta changed
signal, no matter whether the meta is actually changed or not. By the way,
can you tell me where that function is defined? As I don't seem to find it
anywhere in my git checkout.
2011/10/12 Rémi Denis-Courmont <remi at remlab.net>
> On Wed, 12 Oct 2011 14:11:14 +0200, Johannes Marbach
> <johannesmarbach at googlemail.com> wrote:
> > You mean the meta data could possibly be changed between the if
> > and the call to input_item_SetNowPlaying / input_item_SetPublisher? That
> > would imply that we'd need to lock the input item before the if check,
> > right?
> It's not that easy. The lock is not recursive.
> Rémi Denis-Courmont
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel