[vlc-devel] [PATCH] Adjusted meta data signalling to only send events when the meta data has actually changed.

[Johannes Marbach]

You're right, that was the original problem, and this is also addressed by
the patch I posted. While being at it, I thought we could also improve the
meta data signalling by limiting the signal emission to cases, in which the
meta data has actually been changed. But I definitely see you're point. So
if we cannot lock the meta data, I guess it would be best to strip out these
if checks? That way we at least have the correct meta ID for each signal
emission, although the associated meta field might not necessarily been
changed at the time of emission.

2011/10/13 Rémi Denis-Courmont <remi at remlab.net>

> On Wed, 12 Oct 2011 16:20:21 +0200, Johannes Marbach
> <johannesmarbach at googlemail.com> wrote:
> > Just to make sure: In that section of my patch you posted, which of the
> > values do you suspect to possibly be changed after the if statement?
>
> Any meta value can change while the lock is not held, though it's unlikely
> to happen.
>
> Also, I thought the real problem was the incorrect meta ID in the event,
> not the lack of events as such.
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111013/c7ae80d7/attachment.html>