[vlc-devel] [PATCH 07/41] Implement select()-able pipes for OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> On Tue, 11 Oct 2011 20:00:11 +0900, KO Myung-Hun <komh78 at gmail.com> wrote:
>> The reason why I prefer to use 'define',
>>
>>     1. I can reuse the codes without modifying them.
>>     2. I can stop monitoring of the code changes.
>>        This is very important to me because it can save my time
>>        to port.
>>     3. As you know, OS/2 and Win32 have the same root,
>>        so they have the same/similar features and restriction.
>>        As a result, sometimes Win32 specific codes can be used for
>>        OS/2 as well.
>>
>> Nevertheless, if your policy is to use OS-specific codes, I'll do that.'
> 
> Oh no. I'm not saying you should duplicate the code. I'm just saying you
> probably don't need defines. Just replace the existing 'SOCKET' with 'int'
> directly, and so on. It should work just fine on Windows too.
> 

Ok. Fixed. ^^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Implement-select-able-pipes-for-OS-2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111014/60f393b3/attachment.ksh>