[vlc-devel] [PATCH 19/41] Implement thread support for OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> Comments inline...
> 
> Le lundi 10 octobre 2011 14:43:58 KO Myung-Hun, vous avez écrit :
>> ---
>>  include/vlc_common.h  |   15 +
>>  include/vlc_threads.h |   63 ++++
>>  src/Makefile.am       |   13 +
>>  src/os2/thread.c      |  932
>> +++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 1023
>> insertions(+), 0 deletions(-)
>>  create mode 100644 src/os2/thread.c
>>
>> diff --git a/include/vlc_common.h b/include/vlc_common.h
>> index 8e03ed3..95a9531 100644
>> --- a/include/vlc_common.h
>> +++ b/include/vlc_common.h
>> @@ -134,6 +134,9 @@
>>
>>  #define VLC_API VLC_EXTERN VLC_EXPORT
>>
>> +#ifdef __OS2__
>> +#   define pthread_sigmask  sigprocmask
>> +#endif
> 
> That feels a bit out of place.
> Is there any reason why it's not in <vlc_threads.h> ?
> 
>>
>>  /*************************************************************************
>> **** * Basic types definitions
>> @@ -149,6 +152,11 @@
>>   #include <sys/syslimits.h>
>>  #endif
>>
>> +#ifdef __OS2__
>> +#   include <unistd.h>
>> +#   include <time.h>
>> +#endif
>> +
> 
> Those two headers should not be needed in <vlc_common.h>. Normally, files that 
> dependent on them already include them explicitly.
> 

This requires another patch. ^^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0025-Include-missing-unistd.h-and-time.h-for-OS-2.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20111014/f46f9b44/attachment.ksh>