[vlc-devel] [PATCH 19/41] Implement thread support for OS/2

[KO Myung-Hun]

Jean-Baptiste Kempf wrote:
> On Fri, Oct 14, 2011 at 11:41:46PM +0900, KO Myung-Hun wrote :
>> Subject: [PATCH 25/26] Include missing unistd.h and time.h for OS/2
>>
>> ---
>>  modules/access/file.c                              |    2 --
>>  modules/access_output/livehttp.c                   |    4 ++++
>>  modules/control/motion.c                           |    4 ++++
>>  modules/misc/audioscrobbler.c                      |    4 ++++
>>  modules/stream_out/langfromtelx.c                  |    4 ++++
>>  modules/stream_out/rtsp.c                          |    4 ++++
>>  .../video_filter/dynamicoverlay/dynamicoverlay.c   |    4 ++++
>>  src/config/file.c                                  |    3 +++
>>  src/input/es_out_timeshift.c                       |    3 +++
>>  src/input/item.c                                   |    4 ++++
>>  src/interface/interface.c                          |    4 ++++
>>  src/misc/block.c                                   |    5 +++++
>>  src/misc/objects.c                                 |    4 ++++
>>  src/text/filesystem.c                              |    4 ++++
>>  src/video_output/video_epg.c                       |    4 ++++
>>  15 files changed, 55 insertions(+), 2 deletions(-)
> 
> Can't we avoid modifying modules with ifdef for include on special OSes?

No problem.

I just wanted to mark that this was needed only on OS/2.

> Can't we have those includes already included in a header vlc_common or
> vlc_fixed_for_broken_os ?
> 

I have a question. What is the difference of a header vlc_common itself
and a header included already in a header vlc_common ?

Why is not the former acceptable, but the latter is acceptable ?

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr