[vlc-devel] [PATCH 41/41] Enable vlc_poll() on OS/2

[Rémi Denis-Courmont]

Le mardi 18 octobre 2011 15:18:57 KO Myung-Hun, vous avez écrit :
> Rémi Denis-Courmont wrote:
> > On Tue, 11 Oct 2011 20:41:57 +0900, KO Myung-Hun <komh78 at gmail.com> wrote:
> >> How can I confirm this ? At least, I have no experience at all that VLC
> >> is not working as expected.
> > 
> > You need to check how fd_set is laid out, I guess.
> > 
> > If it's a bit field, it won't work.
> > If it's a count of entries followed by a table of values it should work.
> > If it's something else, it probably won't work.
> 
> I updated the patch.
> 
> Although fd_set is not laid out as your suggestion, it has no problem.
> 
> rdset, wrset and exset have enough memory.

Maybe, but the memory allocation is logically flawed even if it works. And 
then you should not copy Windows bugs (!HAVE_ALERTABLE_SELECT).

So basically a dedicated OS/2 file is needed in any case.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis