[vlc-devel] Fix wrong or missing stream length

Laurent Aimar fenrir at elivagar.org
Tue Oct 25 22:53:19 CEST 2011


Sorry for the long delay.

On Fri, Sep 09, 2011 at 06:46:36PM +0200, Tobias Güntner wrote:
> Am 22.08.2011 21:14, schrieb Rémi Denis-Courmont:
>>> - Patch 2 fixes the timestamps (they are one-based, not zero-based)
>> Not sure about this. There are other code paths involving the same attributes.
> New patch attached. Did not touch first/last pts this time.

Patch merged by [22dc9766c517fe7e6a7806737cb8529ba42ef821]. Thanks for your

I slightly modified the test to be more exact (but it doesn't change anything
due to the way ps_pkt_parse_pes() handle timestamp).

>>> - Patch 3 adds a heuristic to handle overflows
> Any suggestions how to improve this?
For example, you could:
 - add a check against the estimated bitrate (when the size is defined)
to detect absurd value (easy)
 - check for multiple SCR values and reject them when too much wrap happens.
(more difficult and increase a bit start up time).



More information about the vlc-devel mailing list