[vlc-devel] [vlc-commits] Support static modules using extern NULL-terminated list

[Rafaël Carré]

Hi,

Le Wed, 31 Aug 2011 19:48:57 +0200,
"Felix Paul Kühne" <fkuehne.videolan at googlemail.com> a écrit :

> On 29.08.2011, at 15:05, Rafaël Carré wrote:
> 
> > vlc | branch: master | Rafaël Carré <rafael.carre at gmail.com> | Mon
> > Aug 29 08:46:05 2011 -0400|
> > [543ee6a25b818c24485c90295b2b12d1183dcbd4] | committer: Rafaël Carré
> > 
> > Support static modules using extern NULL-terminated list
> 
> This breaks building VLC for me:
> 
> Undefined symbols for architecture x86_64:
>   "_vlc_static_modules", referenced from:
>       _module_InitBank in bank.o
> ld: symbol(s) not found for architecture x86_64

Does this work?

diff --git a/src/modules/bank.c b/src/modules/bank.c
index a67128e..45fbeb3 100644
--- a/src/modules/bank.c
+++ b/src/modules/bank.c
@@ -71,7 +71,9 @@ static void module_StoreBank (module_t *module)
     modules.head = module;
 }
 
-#ifdef __GNUC__
+#if defined(__APPLE__)
+__attribute__((weak_import))
+#elif defined(__GNUC__)
 __attribute__((weak))
 #else
 #pragma weak vlc_static_modules



-- 
Rafaël Carré