[vlc-devel] [PATCH 05/21] Update the number of buffers when reconfiguring

Martin Storsjö martin at martin.st
Mon Sep 5 10:57:54 CEST 2011


On Sun, 4 Sep 2011, Rémi Denis-Courmont wrote:

> On Sunday 04 September 2011, Martin Storsjo wrote:
> > From: Martin Storsjö <martin at martin.st>
> > 
> > On OpenMAX devices supported earlier, the number of buffers has
> > stayed the same after reconfiguring, but on the Nexus One, the
> > number changes.
> > 
> > This is a generic bug fix for the omxil module and can
> > be applied to the main tree immediately.
> 
> This lacks error handling.

Ok, will fix.

> It is also suspicious that removed/added buffers pointers are not 
> released/initialized.

Actually, the old ones are released and the new ones initialized already 
(above and below this block in PortReconfigure), this just makes sure the 
buffer count is updated.

// Martin


More information about the vlc-devel mailing list