[vlc-devel] [PATCH 06/21] omxil: Only handle video

[Martin Storsjö]

On Sun, 4 Sep 2011, Rémi Denis-Courmont wrote:

> On Sunday 04 September 2011, Martin Storsjo wrote:
> > From: Martin Storsjö <martin at martin.st>
> > 
> > This works around the issue that a failure to load the omxil
> > module for one codec will kill the global omx core for all other
> > codecs, too, when the failed instance is deinitialized.
> 
> Sure but this does not look like a correct fix.

Well, it fixes it by only trying to use this for video streams, and as 
long as there only is one video stream present at a time, you won't run 
into the issue.

If this workaround was good enough for maemo, perhaps the ifdefs should be 
removed completely (sorry for the ugly style of just commenting them out 
in this patch, I can resubmit a new version that removes them instead of 
commenting them out) to use the same workaround for all platforms.

If you're not ok with extending this workaround to other platforms, the 
proper solution would of course be to add reference counting for the OMX 
core as I mentioned, but that's a bit more work, and in that case, regard 
this patch as a temporary hack in this series.

// Martin