[vlc-devel] [PATCH 08/21] Pass the slice height to CopyOmxPicture

[Martin Storsjö]

On Sun, 4 Sep 2011, Rémi Denis-Courmont wrote:

> On Sunday 04 September 2011, Martin Storsjo wrote:
> > From: Martin Storsjö <martin at martin.st>
> > 
> > This is necessary for handling omx buffers with padding between
> > the planes, indicated by a larger slice height than the actual
> > frame height, occurring on Nexus One with recent CyanogenMod
> > with the OpenMAX driver built from source (opposed to the older
> > ones with a binary-only OpenMAX driver).
> 
> I am not sure what the parameter is (plane height?) but it is odd that the 
> function does not use its new parameter.

In the cases where it was useful to check this parameter, it was the plane 
height, yes. Dunno if the OMX spec says that it always is that, but if 
nSliceHeight > frame_height, I guess one should regard it as plane height.

And indeed it's odd to add the parameter without using it in the same 
patch. This was since the patch currently using it, #9, is a hack that 
isn't intended to be permanent.

// Martin