[vlc-devel] [PATCH 06/21] omxil: Only handle video

[Martin Storsjö]

On Mon, 5 Sep 2011, Rémi Denis-Courmont wrote:

> On Mon, 5 Sep 2011 12:05:16 +0300 (EEST), Martin Storsjö
> <martin at martin.st>
> wrote:
> > If this workaround was good enough for maemo, perhaps the ifdefs should
> be 
> > removed completely (sorry for the ugly style of just commenting them out
> 
> > in this patch, I can resubmit a new version that removes them instead of
> 
> > commenting them out) to use the same workaround for all platforms.
> 
> The N900 port never reached "production" or "release" status.

Ah, didn't know that...

> So I'm not sure you should take it as a reference, unless VLC Android is 
> only intended as a PoC.

I guess VLC for android in itself isn't inteded as a PoC, but this 
patchset isn't much more than that at the moment.

> I don't know what your requirements are, but it should not be
> difficult to protect concurrent accesses with a static mutex.

Probably isn't hard, no. In addition to that, the dll_handle and function 
pointers that currently are a part of the omxil decoder_sys_t should be 
split out to some global struct that is shared between all the instances. 
Anyone more familiar with the VLC coding style and internals who would be 
willing to do that? :-)

On a second thought, this patch isn't necessary if you want to use IOMX, 
where the actual OMX context is in the mediaserver and only accessed via 
IPC APIs - this patch only is relevant when testing direct OMX access on 
rooted devices...

// Martin