[vlc-devel] [PATCH 17/21] Pretend that the new qcom pixel format is normal I420

[Rémi Denis-Courmont]

Le lundi 5 septembre 2011 15:31:21 Martin Storsjö, vous avez écrit :
> This is a hack for testing decoders producing this (HTC Sensation).
> ---
>  modules/codec/omxil/utils.cpp |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/modules/codec/omxil/utils.cpp b/modules/codec/omxil/utils.cpp
> index 3940c85..5ef3e4c 100644
> --- a/modules/codec/omxil/utils.cpp
> +++ b/modules/codec/omxil/utils.cpp
> @@ -392,6 +392,7 @@ static const struct
>      { VLC_CODEC_I420, OMX_COLOR_FormatYUV420PackedPlanar, 3, 1, 2 },
>      { VLC_CODEC_I420, OMX_COLOR_FormatYUV420SemiPlanar, 3, 1, 2 },
>      { VLC_CODEC_I420, (OMX_COLOR_FORMATTYPE)
> OMX_QCOM_COLOR_FormatYVU420SemiPlanar, 3, 1, 2 }, +    { VLC_CODEC_I420,
> (OMX_COLOR_FORMATTYPE)
> QOMX_COLOR_FormatYUV420PackedSemiPlanar64x32Tile2m8ka, 3, 1, 2 }, {
> VLC_CODEC_YUYV, OMX_COLOR_FormatYCbYCr, 4, 2, 0 },
>      { VLC_CODEC_YVYU, OMX_COLOR_FormatYCrYCb, 4, 2, 0 },
>      { VLC_CODEC_UYVY, OMX_COLOR_FormatCbYCrY, 4, 2, 0 },

This really need to use a custom codec value. If you don't want to define a 
new VLC_CODEC, at least use a new VLC_FOURCC.

I have to assume that whatever OMX outputs, something can use as input, so 
converting silently may not be the smartest thing to do.


-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis