[vlc-devel] [PATCH] Stereoscopy merge

[Jean-Baptiste Kempf]

On Tue, Sep 13, 2011 at 02:39:25AM +0930, Andrew Price wrote :
> These patches are created from the stable code in my stereoscopy branch
> (including nVidia 3D Vision support). There's a total of 7 patches to be
> applied in order.
> 
> I created these patches using "git format-patch". This is my first attempt
> to post a patch on here, so my apologies if it's in an incorrect format.

This is really cool and this is in correct format.

However, you should use git rebase -i origin/master in order to
reordonate the patches and merge patches that should be merged.
Indeed, it is a bit hard to review when something is then
modified/reverted in the next patch.

You could go even further and do a git reset (after saving all your
changes) and then recreates the patches in a more "logical" way.
For example, I would suggest that you do:
 - one patch for the nvidia wrapper
 - one (or more) patch for the include and src/ changes
 - one (or more) patch for the D3D modifications
 - one (or more) patch for the stereoscopy.c video filter
 - one patch for the Qt4 Ui changes


Anyway, this is very impressive work... Thanks a lot.


Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device