[vlc-devel] [PATCH] libass: srt support

[Jean-Baptiste Kempf]

On Sun, Sep 11, 2011 at 11:36:44PM +0200, Mathieu Velten wrote :
> >> +#define FFMIN(a,b) ((a) > (b) ? (b) : (a))
> >
> > Seriously? not __MIN ?
> 
> See below.

I don't see the reason...

> >> +    int i;
> >> +    ASS_Event* evt = track->events + track->n_events - 1;
> >> +
> >> +    for (i = 0; i<track->n_events - 1; ++i) // ignoring last event, it is the one we are comparing with
> >
> > VLC is C99.
> 
> I tried to keep the code as close as possible from the mplayer code to
> ease a possible update. I will update my patch accordingly.

Hmm, why not.

> > Are you sure there are no regressions with the SubRip test suite?
> 
> I don't know what this is and where to find it.

http://ale5000.altervista.org/subtitles.htm

> > Has this code been fuzzed?
> 
> Not by me, I guess it has been done before inclusion in mplayer.

mplayer doesn't fuzz usually.

> How can I do that easily ? Isolate the function and launch it on
> random generated string ?

Take a normal ssa file and use zzuf to break it.

Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device