[vlc-devel] [PATCH] opengl: enables shaders for macos opengl.

[Sebastien Zwickert]

On Sep 13, 2011, at 9:41 PM, Laurent Aimar wrote:
> On Tue, Sep 13, 2011 at 09:24:19PM +0200, Sebastien Zwickert wrote:
>> 
>> On Sep 13, 2011, at 8:52 PM, Laurent Aimar wrote:
>>> On Tue, Sep 13, 2011 at 08:50:53PM +0200, Laurent Aimar wrote:
>>>> Couldn't we simply remove all the specific macosx part?
>>>> Is there
>>>> a performance loss?
>>> 
>>> I am asking because:
>>> - it would be simpler to maintain
>>> - I think it would also be faster as it would avoid a full frame
>>> copy BUT it needs to be tested to be sure.

A new patch in attachment that enables shaders for macos opengl and cleans a lot of specific macos part.
I've not removed the macos case for defining texture parameters. According to apple's doc it uses recommended data format and type combination[1].

About performance i used OpenGL Profiler to look time spent in OpenGL and the Activity Monitor app to look the CPU usage.
I played the first minutes of Big Buck Bunny 1920*1080 H264 for tests.

Current code from trunk : CPU ~65% time spent in OpenGL ~7%
First patch sent : CPU ~50% time spent in OpenGL ~14%
Patch in attachment : CPU ~50% time spent in OpenGL ~10%


Best regards,

Sebastien

--
[1] see optimal data formats and types : http://developer.apple.com/library/mac/#documentation/GraphicsImaging/Conceptual/OpenGL-MacProgGuide/opengl_texturedata/opengl_texturedata.html


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-opengl-enables-shaders-for-macos-opengl-an-cleans-so.patch
Type: application/octet-stream
Size: 9486 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110914/3b85a88e/attachment.obj>